Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not obtain storage snapshot for each INSERT block (slightly improves performance) #40638

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

azat
Copy link
Collaborator

@azat azat commented Aug 25, 2022

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Do not obtain storage snapshot for each INSERT block (slightly improves performance)

It depends on how much parts do you have, but for some workload with
InMemory only parts w/o merges, I got 5% increase.

…mance)

It depends on how much parts do you have, but for some workload with
InMemory only parts w/o merges, I got 5% increase.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat changed the title Do not obtain storage snapshot for each INSERT block (improves performance) Do not obtain storage snapshot for each INSERT block (slightly improves performance) Aug 25, 2022
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-performance Pull request with some performance improvements label Aug 25, 2022
@Avogar Avogar self-assigned this Sep 7, 2022
@Avogar Avogar merged commit 8513af5 into ClickHouse:master Sep 7, 2022
@azat azat deleted the mergetree/insert-perf branch September 9, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants