-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix columnObject crash with array of variadic dimension elems #40483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Aug 22, 2022
Avogar
added
the
can be tested
Allows running workflows for external contributors
label
Aug 22, 2022
Test fail reason: SELECT CAST('{"x" : [ {} , [ 1 , 2] ]}', 'Object(\'json\')');
Expect: {"x" : [ [] , [ 1 , 2] ]}'
Return: {"x" : [ [0] , [ 1 , 2] ]}' Finding the cause. |
Integration case fail not relates. ASTFuzzer fail because it generate a query with |
Wait for #40754 |
CurtizJ
approved these changes
Aug 31, 2022
Fuzzer failures will be fixed by #40754 and are not related to changes in this PR, so let's merge now. |
CurtizJ
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Aug 31, 2022
This was referenced Aug 31, 2022
Closed
Merged
Merged
CurtizJ
added a commit
that referenced
this pull request
Sep 1, 2022
Backport #40483 to 22.8: Fix columnObject crash with array of variadic dimension elems
CurtizJ
added a commit
that referenced
this pull request
Sep 1, 2022
Backport #40483 to 22.7: Fix columnObject crash with array of variadic dimension elems
CurtizJ
added a commit
that referenced
this pull request
Sep 1, 2022
Backport #40483 to 22.6: Fix columnObject crash with array of variadic dimension elems
robot-ch-test-poll
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Object
that contains arrays of variadic dimension.Close #40333
Following queries will crash the server without need to
SET allow_experimental_object_type=1
The crash reason is column object assume all elements in array have same dimension and lead to segfault in serialization. The solution can be either (1) disallow variadic dimension in array, or (2) fold elements in array to same dimensions. This MR implements approach (2).
I personally think approach (2) is consistent to #23516 as we can consider high dimension arrays as super-type of lower dimension arrays of the same type.