Rename log when rename merge tree tables #39227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-bugfix
azat
reviewed
Jul 14, 2022
| { | ||
| IStorage::renameInMemory(new_table_id); | ||
| std::atomic_store(&log_name, std::make_shared<String>(new_table_id.getNameForLogs())); | ||
| log = &Poco::Logger::get(*log_name); |
There was a problem hiding this comment.
Interesting. Maybe it should be a general approach for all tables?
P.S. I was thinking about more general logging than right now sometime before, i.e. move log into the IStorage, that way it will have the same format for all engines
Avogar
approved these changes
Jul 26, 2022
tavplubix
reviewed
Jul 26, 2022
| Poco::Logger * log; | ||
| /// log_name will change during table RENAME. Use atomic_shared_ptr to allow concurrent RW. | ||
| /// NOTE clang-14 doesn't have atomic_shared_ptr yet. Use std::atomic* operations for now. | ||
| std::shared_ptr<String> log_name; |
There was a problem hiding this comment.
Maybe remove log_name and return getStorageID().getNameForLogs() from getLogName()?
|
Also this PR does not update logger name in other places (see usages of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong table name in logs after RENAME TABLE. This fixes #38018