Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Function): add isNullable function #38841

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Conversation

lokax
Copy link
Contributor

@lokax lokax commented Jul 5, 2022

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support isNullable function. This function checks whether it's argument is nullable and return true(1) or false(0).
Closes #38611

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label Jul 5, 2022
@Avogar Avogar self-assigned this Jul 5, 2022
@Avogar Avogar added the can be tested Allows running workflows for external contributors label Jul 5, 2022
@Avogar
Copy link
Member

Avogar commented Jul 6, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

update

✅ Branch has been successfully updated

@Avogar
Copy link
Member

Avogar commented Jul 7, 2022

Everything is great, I am going to merge this PR.
Congratulations on your first contribution to ClickHouse!

@Avogar Avogar marked this pull request as ready for review July 7, 2022 09:49
@Avogar Avogar merged commit 7c60714 into ClickHouse:master Jul 7, 2022
@@ -0,0 +1,5 @@
SELECT isNullable(3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for LowCardinality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isNullable function
4 participants