clickhouse client/local interactive: support \i file #38813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
kssenii
changed the title
| return false; | ||
|
|
||
| if (trimmed_input.starts_with("\\i")) |
There was a problem hiding this comment.
Ok. But is it possible to group the code with others (backslash_aliases)?
There was a problem hiding this comment.
I wanted to do that at first, but switched to current way as backslash_aliases just rewrite input text while for \i need a different code for execution of queries so it seemed better to put this inside processQueryText.
alexey-milovidov
approved these changes
Jul 4, 2022
| spawn bash -c "source $basedir/../shell_config.sh ; \$CLICKHOUSE_CLIENT --disable_suggestion" | ||
| expect ":) " | ||
|
|
||
| send -- "\\i queries_02352\r" |
There was a problem hiding this comment.
Maybe also add a case with \i queries_02352; (semicolon is trimmed) as well as
\i a file with whitespace ;
(extra whitespaces in the beginning and at the end trimmed, other preserved)
alexey-milovidov
approved these changes
Jul 4, 2022
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Oct 25, 2023
porting ClickHouse/ClickHouse#38813 (Jul 4, 2022)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support
\i filein clickhouse client / local (similar to psql \i).