Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed in TranslateQualifiedNamesMatcher #38136

Merged
merged 9 commits into from
Jul 1, 2022

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented Jun 16, 2022

fixed a bug in TranslateQualifiedNamesMatcher to handle a nested tuple field with the table qualified name.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

With table

CREATE TABLE nested_name_tuples
(
    `a` Tuple(x String, y Tuple(i Int32, j String))
)
ENGINE = Memory;

the following query throws an exception of UNKNOWN_IDENTIFIER.

SELECT t.a.y.i FROM nested_name_tuples as t;

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

fixed a bug in TranslateQualifiedNamesMatcher to handle nested tuple field with the table qulified name
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 16, 2022
@vdimir vdimir added the can be tested Allows running workflows for external contributors label Jun 16, 2022
@lgbo-ustc lgbo-ustc marked this pull request as ready for review June 17, 2022 01:30
@lgbo-ustc lgbo-ustc marked this pull request as draft June 17, 2022 02:26
@lgbo-ustc lgbo-ustc marked this pull request as ready for review June 17, 2022 04:19
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Jun 29, 2022
Copy link
Member

@yakov-olkhovskiy yakov-olkhovskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, see some suggestions...

src/Interpreters/TranslateQualifiedNamesVisitor.cpp Outdated Show resolved Hide resolved
src/Interpreters/TranslateQualifiedNamesVisitor.cpp Outdated Show resolved Hide resolved
src/Interpreters/TranslateQualifiedNamesVisitor.cpp Outdated Show resolved Hide resolved
@yakov-olkhovskiy yakov-olkhovskiy merged commit 776a80b into ClickHouse:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants