Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible crash in Distributed async insert in case of removing a replica from config. #38029

Conversation

KochetovNicolai
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix possible crash in Distributed async insert in case of removing a replica from config.

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jun 13, 2022
@nikitamikhaylov
Copy link
Member

Maybe related? #25768

@KochetovNicolai
Copy link
Member Author

I think this is the different issue (I am fixing a possible crash)

@KochetovNicolai
Copy link
Member Author

Style is broken in some js code

@KochetovNicolai KochetovNicolai added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jun 15, 2022
@KochetovNicolai
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2022

update

✅ Branch has been successfully updated

@devcrafter devcrafter self-assigned this Jun 20, 2022
@KochetovNicolai KochetovNicolai merged commit fab6251 into master Jun 20, 2022
@KochetovNicolai KochetovNicolai deleted the fix-possible-crash-after-removing-replica-in-distributed branch June 20, 2022 09:38
KochetovNicolai added a commit that referenced this pull request Jun 20, 2022
…moving-replica-in-distributed

Fix possible crash in Distributed async insert in case of removing a replica from config.

(cherry picked from commit fab6251)
robot-clickhouse pushed a commit that referenced this pull request Jun 20, 2022
…sert in case of removing a replica from config.',)
robot-clickhouse pushed a commit that referenced this pull request Jun 20, 2022
…sert in case of removing a replica from config.',)
robot-clickhouse pushed a commit that referenced this pull request Jun 20, 2022
…sert in case of removing a replica from config.',)
robot-clickhouse pushed a commit that referenced this pull request Jun 20, 2022
…sert in case of removing a replica from config.',)
KochetovNicolai added a commit that referenced this pull request Jul 19, 2022
Backport #38029 to 22.4: ('Fix possible crash in Distributed async insert in case of removing a replica from config.',)
KochetovNicolai added a commit that referenced this pull request Jul 19, 2022
Backport #38029 to 22.5: ('Fix possible crash in Distributed async insert in case of removing a replica from config.',)
KochetovNicolai added a commit that referenced this pull request Jul 19, 2022
Backport #38029 to 22.6: ('Fix possible crash in Distributed async insert in case of removing a replica from config.',)
robot-clickhouse pushed a commit that referenced this pull request Jul 19, 2022
…rt in case of removing a replica from config.
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 19, 2022
@devcrafter devcrafter removed their assignment Jul 19, 2022
KochetovNicolai added a commit that referenced this pull request Aug 1, 2022
Backport #38029 to 21.8: Fix possible crash in Distributed async insert in case of removing a replica from config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants