-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible crash in Distributed async insert in case of removing a replica from config. #38029
Merged
KochetovNicolai
merged 6 commits into
master
from
fix-possible-crash-after-removing-replica-in-distributed
Jun 20, 2022
Merged
Fix possible crash in Distributed async insert in case of removing a replica from config. #38029
KochetovNicolai
merged 6 commits into
master
from
fix-possible-crash-after-removing-replica-in-distributed
Jun 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replica from config.
robot-ch-test-poll
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jun 13, 2022
Maybe related? #25768 |
I think this is the different issue (I am fixing a possible crash) |
Style is broken in some js code |
KochetovNicolai
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Jun 15, 2022
@Mergifyio update |
✅ Branch has been successfully updated |
KochetovNicolai
deleted the
fix-possible-crash-after-removing-replica-in-distributed
branch
June 20, 2022 09:38
KochetovNicolai
added a commit
that referenced
this pull request
Jun 20, 2022
…moving-replica-in-distributed Fix possible crash in Distributed async insert in case of removing a replica from config. (cherry picked from commit fab6251)
This was referenced Jun 20, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 20, 2022
…sert in case of removing a replica from config.',)
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 20, 2022
…sert in case of removing a replica from config.',)
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 20, 2022
…sert in case of removing a replica from config.',)
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 20, 2022
…sert in case of removing a replica from config.',)
KochetovNicolai
added a commit
that referenced
this pull request
Jul 19, 2022
Backport #38029 to 22.4: ('Fix possible crash in Distributed async insert in case of removing a replica from config.',)
KochetovNicolai
added a commit
that referenced
this pull request
Jul 19, 2022
Backport #38029 to 22.5: ('Fix possible crash in Distributed async insert in case of removing a replica from config.',)
KochetovNicolai
added a commit
that referenced
this pull request
Jul 19, 2022
Backport #38029 to 22.6: ('Fix possible crash in Distributed async insert in case of removing a replica from config.',)
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 19, 2022
…rt in case of removing a replica from config.
robot-ch-test-poll
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jul 19, 2022
KochetovNicolai
added a commit
that referenced
this pull request
Aug 1, 2022
Backport #38029 to 21.8: Fix possible crash in Distributed async insert in case of removing a replica from config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible crash in
Distributed
async insert in case of removing a replica from config.