"Partition pruning" for s3 #37356
Merged
"Partition pruning" for s3 #37356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
amosbird
commented
May 19, 2022
| @@ -250,7 +250,10 @@ ColumnPtr IExecutableFunction::executeWithoutSparseColumns(const ColumnsWithType | |||
| : columns_without_low_cardinality.front().column->size(); | |||
|
|
|||
| auto res = executeWithoutLowCardinalityColumns(columns_without_low_cardinality, dictionary_type, new_input_rows_count, dry_run); | |||
| auto keys = res->convertToFullColumnIfConst(); | |||
| bool res_is_constant = isColumnConst(*res); | |||
There was a problem hiding this comment.
When default implementation is used, Const(LowCardinality(...)) loses its constant property and becomes LowCardinality(...), which in turn disables pruning with virtual columns.
Here is the fix.
amosbird
commented
May 19, 2022
| bool has_wildcards = s3_configuration.uri.bucket.find(PARTITION_ID_WILDCARD) != String::npos | ||
| || keys.back().find(PARTITION_ID_WILDCARD) != String::npos; | ||
| if (partition_by && has_wildcards) | ||
| throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Reading from a partitioned S3 storage is not implemented yet"); |
There was a problem hiding this comment.
It's not possible to read from a partitioned S3 storage for now (it always returns empty). Let's throw an exception instead.
amosbird
commented
May 19, 2022
| select * from s3(s3_conn, filename='test_02302_*', format=Parquet) where _file like '%5'; | ||
|
|
||
| -- Test s3 table with explicit keys (no glob) | ||
| -- TODO support truncate table function |
There was a problem hiding this comment.
In order to construct an S3 storage with explicit keys, I have to apply the following clumsy steps. Things can be improved:
- allow to do
truncate table function s3(...) - allow to create an S3 storage with a list of keys (or even different buckets)
amosbird
force-pushed
the
partition-prune-for-s3
branch
from
afbb275 to
7931683
Compare
amosbird
force-pushed
the
partition-prune-for-s3
branch
from
21a979c to
1ee02a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow to prune the list of files via virtual columns such as
_fileand_pathwhen reading from S3. This is for #37174 , #23494