-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enable LLVM for JIT compilation in CMake #35683
Conversation
contrib/llvm-cmake/CMakeLists.txt
Outdated
@@ -2,11 +2,12 @@ | |||
# tools to be build for host architecture and everything else for target architecture (e.g. AArch64) | |||
# Possible workaround is to use llvm-tblgen from some package... | |||
# But lets just enable LLVM for native builds | |||
if (CMAKE_CROSSCOMPILING OR SANITIZE STREQUAL "undefined") | |||
if (NOT (${CMAKE_SYSTEM_NAME} MATCHES ${CMAKE_HOST_SYSTEM_NAME}) OR SANITIZE STREQUAL "undefined") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMAKE_CROSSCOMPILING can be true even without cross compilation
This variable will be set to true by CMake if the [CMAKE_SYSTEM_NAME]
(https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_NAME.html#variable:CMAKE_SYSTEM_NAME)
variable has been set manually (i.e. in a toolchain file or as a cache entry from the [cmake]
https://cmake.org/cmake/help/latest/variable/CMAKE_CROSSCOMPILING.html
One of latest builds on master:
|
@Mergifyio update |
✅ Branch has been successfully updated |
@Felixoid our previous wrong fix affects only v22.3.2.2-lts v22.3.1.1262-prestable. |
Yep, we can release a new version |
9fa4fc0
to
4c336c4
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
@kitaisreal you forgot to take a look at failed tests before merging again: So seems like it was broken here somehow. I will try to revert. |
@tavplubix I take a look this change just revert other pull request that breaks LLVM compilation, everything must work as before. |
The problem was in settings randomization, in particular |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable build with JIT compilation by default.