Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages/Kafka: fixed deadlocks, moved to background pool #3215

Merged
merged 3 commits into from
Oct 1, 2018

Commits on Sep 26, 2018

  1. Storages/Kafka: fixed deadlocks, moved to background pool

    This fixes two deadlocks in Kafka engine found previously:
    * When exception is thrown before starting reading, consumer
      was never returned to the storage. Now it is claimed only
      when actually starting reading.
    * Fixed lockup on deinitialization when consumer only unsubscribed,
      but didn't close, and the endine then timeouted when waiting for
      consumer destruction.
    
    This also moves the stream thread to background worker pool.
    The reason for that is that it will compete with other tasks for
    time, so it will form a backpressure on insertion when the system
    is busy.
    vavrusa committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    ea32434 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. Configuration menu
    Copy the full SHA
    b9e6b02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb0f76d View commit details
    Browse the repository at this point in the history