Format ODBCDriver2 with NULL support #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * ODBC driver is designed to be build for different platforms without dependencies from the main code, | ||
| * so the format is made that way so that it can be as easy as possible to parse it. | ||
| * A header is displayed with the required information. | ||
| * The data is then output in the order of the rows. Each value is displayed as follows: length in VarUInt format, then data in text form. |
|
|
||
| void writeODBCString(WriteBuffer & out, const char * cstr) | ||
| { | ||
| std::string str{cstr}; |
| out.write(str.data(), str.size()); | ||
| } | ||
|
|
||
| void writeODBCString(WriteBuffer & out, const char * cstr) |
There was a problem hiding this comment.
No need for this method. It will work automatically by implicit type conversion.
There was a problem hiding this comment.
it does not work for writeODBCString(out, "woow")
| } | ||
| } | ||
|
|
||
| void ODBCDriver2BlockOutputStream::writePrefix() |
There was a problem hiding this comment.
I cannot understand the motivation behind this format.
There was a problem hiding this comment.
expandable header without breaking format - we can send any column flags, for example length for display_size or something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en