Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind fix for AppleClang version and char8_t support check #10705

Conversation

traceon
Copy link
Contributor

@traceon traceon commented May 6, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Non-significant (changelog entry is not required)

Detailed description:
Added checks for AppleClang versions to allow them if it is Xcode 10.2+. Main known issue was char8_t support, which was added in Clang 7 (enabled with -std=c++20 -fchar8_t) and is enabled by default starting Clang 8 if only -std=c++20 is specified, according to https://clang.llvm.org/cxx_status.html
This is blind fix, verified to work only on Xcode 11.4.1.

The correspondence between AppleClang and upstream Clang versions is guessed based on:

@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 6, 2020
@alexey-milovidov alexey-milovidov merged commit 69dcd80 into ClickHouse:master May 6, 2020
@traceon traceon deleted the apple-clang-version-check-char8_t-fix branch May 8, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-docs-needed pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants