Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LES domain height fetch #962

Merged
merged 1 commit into from
May 2, 2022
Merged

Fix LES domain height fetch #962

merged 1 commit into from
May 2, 2022

Conversation

ilopezgp
Copy link
Contributor

@ilopezgp ilopezgp commented May 2, 2022

Fixes the LES domain height fetch. In PyCLES, the centers precede the faces:

z_half = [Δz/2, Δz + Δz/2, ..., z_max - Δz/2]
z = [Δz, 2Δz, ..., z_max]

Therefore, to get the domain height, we need to fetch the last element of z, not of z_half.

@ilopezgp
Copy link
Contributor Author

ilopezgp commented May 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented May 2, 2022

Build succeeded:

@bors bors bot merged commit c0f0431 into main May 2, 2022
@bors bors bot deleted the fix_les_z branch May 2, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairchn yairchn yairchn approved these changes

@charleskawczynski charleskawczynski Awaiting requested review from charleskawczynski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilopezgp @yairchn