-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move nh_pressure computation to /closures folder #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
force-pushed
the
yc/call_press_closure
branch
from
August 9, 2021 16:14
c0ab33e
to
77ecae0
Compare
jiahe23
reviewed
Aug 9, 2021
jiahe23
reviewed
Aug 9, 2021
yairchn
force-pushed
the
yc/call_press_closure
branch
2 times, most recently
from
August 9, 2021 20:29
a31b317
to
0358072
Compare
We need to fix the git conflicts |
charleskawczynski
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we just need to rebase
jiahe23
reviewed
Aug 9, 2021
jiahe23
reviewed
Aug 9, 2021
yairchn
force-pushed
the
yc/call_press_closure
branch
2 times, most recently
from
August 9, 2021 21:42
111de7a
to
158f907
Compare
move nh_pressure to closures update tables
yairchn
force-pushed
the
yc/call_press_closure
branch
from
August 9, 2021 21:48
158f907
to
82acbf5
Compare
Bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR moves the nh_pressure computation to /closures folder