Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add moisture model docs #957

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Add moisture model docs #957

merged 1 commit into from
Apr 29, 2022

Conversation

trontrytel
Copy link
Member

As promised, following up with a quick docs entry related to moisture_model.

@trontrytel trontrytel added the documentation Improvements or additions to documentation label Apr 28, 2022
@trontrytel trontrytel self-assigned this Apr 28, 2022
ilopezgp
ilopezgp reviewed Apr 28, 2022
View reviewed changes
docs/src/EDMFEquations.md Outdated Show resolved Hide resolved
docs/src/EDMFEquations.md Outdated Show resolved Hide resolved
@trontrytel @ilopezgp
add moisture model docs
5ff4b63 
Co-authored-by: Ignacio Lopez-Gomez <[email protected]>
charleskawczynski
charleskawczynski approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We could decompose the EDMF equations docs into sections, I didn’t do that in climate machine to avoid too many files, but it may actually make sense in the TC repo. We can certainly leave that for a separate PR, though.

@trontrytel
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 29, 2022

Build succeeded:

@bors bors bot merged commit d2a3780 into main Apr 29, 2022
@bors bors bot deleted the aj/update_docs branch April 29, 2022 17:00
@trontrytel trontrytel mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopezgp ilopezgp ilopezgp left review comments

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees

@trontrytel trontrytel

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trontrytel @charleskawczynski @ilopezgp