Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bcs and avoid accessing ghost points #74

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Use bcs and avoid accessing ghost points #74

merged 2 commits into from
Aug 3, 2021

Conversation

charleskawczynski
Copy link
Member

This should help us move towards removing ghost points.

@charleskawczynski
Copy link
Member Author

charleskawczynski commented Aug 3, 2021 •
edited
Loading

So, this is technically behavior changing because, previously, ∇U reached to ghost points, which did not necessarily enforce 0 Neumann BCs. But I think that this is close enough--we could also change it to Extrapolate down the road if needed. The reason I went with 0 Neumann is because it looks like all BCs--except W-- in set_bcs behave this way.

@charleskawczynski charleskawczynski added enhancement New feature or request and removed Refactor ⚙️ labels Aug 3, 2021
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 3, 2021

Build succeeded:

@bors bors bot merged commit bd8643d into main Aug 3, 2021
@bors bors bot deleted the ck/refactor branch August 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski