Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to improve type inference #568

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Try to improve type inference #568

merged 1 commit into from
Nov 17, 2021

Conversation

charleskawczynski
Copy link
Member

This PR passes n_updrafts as a type parameter so that we can potentially unroll some updraft loops. In addition, we avoid calling ntuple where it's not necessarily needed.

yairchn
yairchn approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 17, 2021

Build succeeded:

@bors bors bot merged commit 074fa5e into main Nov 17, 2021
@bors bors bot deleted the ck/reduce_allocs3 branch November 17, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairchn yairchn yairchn approved these changes

Assignees
No one assigned
Labels
Performance 🚀 Refactor ⚙️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @yairchn