Change update interface, rename to step #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/refactor
branch
from
6eeb21c
to
bdde426
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
552: Change update interface, rename to step r=charleskawczynski a=charleskawczynski This is a prep PR for #473. This PR - renames `update` to `step!` - Changes the `step!` interface to be compatible with OrdinaryDiffEq.jl - Moves the `State` definition into TC.jl `src/`, so that we can pass its properties into a local struct and continue using the dycore API Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/refactor
branch
from
bdde426
to
ccbb4ff
Compare
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
552: Change update interface, rename to step r=charleskawczynski a=charleskawczynski This is a prep PR for #473. This PR - renames `update` to `step!` - Changes the `step!` interface to be compatible with OrdinaryDiffEq.jl - Moves the `State` definition into TC.jl `src/`, so that we can pass its properties into a local struct and continue using the dycore API Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
ilopezgp
referenced
this pull request
Nov 17, 2021
570: Bump version to 0.6.0 r=ilopezgp a=ilopezgp Co-authored-by: ilopezgp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prep PR for #473. This PR
updatetostep!step!interface to be compatible with OrdinaryDiffEq.jlStatedefinition into TC.jlsrc/, so that we can pass its properties into a local struct and continue using the dycore API