Move purely diagnostic fields outside of src #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/prep_ode
branch
from
53ab6da
to
bb2ead3
Compare
|
I don't think this should cause problems for the pipeline, but since we're moving things outside of |
ilopezgp
reviewed
Nov 9, 2021
yairchn
reviewed
Nov 9, 2021
charleskawczynski
force-pushed
the
ck/prep_ode
branch
from
bb2ead3
to
7291ee2
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2021
549: Move purely diagnostic fields outside of src r=charleskawczynski a=charleskawczynski This PR moves the purely diagnostic computations outside of `src/`. This will effectively prevent #468 from reemerging (since we won't have access to these fields inside `src/`). This is going to cause a bunch of conflicts with the ODE branch, but I think that we can perhaps do that a bit more incrementally. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2021
549: Move purely diagnostic fields outside of src r=charleskawczynski a=charleskawczynski This PR moves the purely diagnostic computations outside of `src/`. This will effectively prevent #468 from reemerging (since we won't have access to these fields inside `src/`). This is going to cause a bunch of conflicts with the ODE branch, but I think that we can perhaps do that a bit more incrementally. Co-authored-by: Charles Kawczynski <[email protected]>
charleskawczynski
force-pushed
the
ck/prep_ode
branch
from
7291ee2
to
e6a895d
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
ilopezgp
referenced
this pull request
Nov 17, 2021
570: Bump version to 0.6.0 r=ilopezgp a=ilopezgp Co-authored-by: ilopezgp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the purely diagnostic computations outside of
src/. This will effectively prevent #468 from reemerging (since we won't have access to these fields insidesrc/).This is going to cause a bunch of conflicts with the ODE branch, but I think that we can perhaps do that a bit more incrementally.