Fix translation bug in ref state bcs #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With these changes, ~120 fields in TRMM_LBA match scampy to ~1e-9 (max mse) at the 20th timestep. |
|
bors r+ |
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
========================================
- Coverage 0.02% 0.02% -0.01%
========================================
Files 23 23
Lines 3499 3503 +4
========================================
Hits 1 1
- Misses 3498 3502 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely not what we want in the end, but for early-on comparisons, and perhaps if there are assumptions elsewhere about how the ref state bcs are applied, this PR fixes a translation bug in the ref state bcs: in SCAMPy, the
p_halffield has two missing elements at the start and end of the array, and both points are mirrored in log-space about the boundary. This enters the computations here.