Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add correction to run without tests #41

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

yairchn
Copy link
Member

@yairchn yairchn commented Jul 22, 2021

without this fix running:
julia --project integration_tests/utils/generate_namelist.jl Soares
julia --project integration_tests/utils/main.jl Soares
breaks with:

"""""

ERROR: LoadError: KeyError: key "uuid" not found
Stacktrace:
[1] getindex(h::Dict{String, Any}, key::String)
@ Base ./dict.jl:482
[2] TurbulenceConvection.NetCDFIO_Stats(namelist::Dict{String, Any}, Gr::TurbulenceConvection.Grid{OffsetArrays.OffsetVector{Float64, Vector{Float64}}, Float64})
@ TurbulenceConvection ~/Documents/codes/TurbulenceConvection.jl/src/NetCDFIO.jl:29
[3] Simulation1d(namelist::Dict{String, Any})
@ Main ~/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:27
[4] main1d(namelist::Dict{String, Any}; time_run::Bool)
@ Main ~/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:105
[5] main1d
@ ~/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:105 [inlined]
[6] #main#1
@ ~/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:101 [inlined]
[7] main(namelist::Dict{String, Any})
@ Main ~/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:101
[8] top-level scope
@ ~/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:138
in expression starting at /Users/yaircohen/Documents/codes/TurbulenceConvection.jl/integration_tests/utils/main.jl:130

"""""

as uuid is only added in the test file.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #41 (bf8a7d9) into main (021a6d9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #41   +/-   ##
=====================================
  Coverage   0.02%   0.02%           
=====================================
  Files         22      22           
  Lines       3527    3527           
=====================================
  Hits           1       1           
  Misses      3526    3526           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021a6d9...bf8a7d9. Read the comment docs.

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleskawczynski
Copy link
Member

bors r+

@bors bors bot merged commit 1d83178 into main Jul 22, 2021
@bors bors bot deleted the yc/bug_fix_running_wo_tests branch July 22, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants