Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions #39

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Remove unused functions #39

merged 1 commit into from
Jul 26, 2021

Conversation

charleskawczynski
Copy link
Member

Remove unused functions, fix some typos. I don't think these extra functions are needed, but it would be nice to get confirmation.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #39 (960f5c0) into main (35d47ce) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #39   +/-   ##
=====================================
  Coverage   0.02%   0.02%           
=====================================
  Files         22      22           
  Lines       3530    3493   -37     
=====================================
  Hits           1       1           
+ Misses      3529    3492   -37     
Impacted Files Coverage Δ
src/Forcing.jl 0.00% <0.00%> (ø)
src/ReferenceState.jl 0.00% <ø> (ø)
src/Turbulence_PrognosticTKE.jl 0.00% <ø> (ø)
src/microphysics_functions.jl 0.00% <ø> (ø)
src/turbulence_functions.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d47ce...960f5c0. Read the comment docs.

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure about the entr_detr_env_moisture_deficit_b_ED_MF not being needed at some point @yairchn ?

Copy link
Member

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the entrainment functions that are there

src/turbulence_functions.jl Outdated Show resolved Hide resolved
@charleskawczynski
Copy link
Member Author

bors r+

@bors bors bot merged commit 35f00a6 into main Jul 26, 2021
@bors bors bot deleted the ck/cleanup branch July 26, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants