-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused functions #39
Conversation
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
=====================================
Coverage 0.02% 0.02%
=====================================
Files 22 22
Lines 3530 3493 -37
=====================================
Hits 1 1
+ Misses 3529 3492 -37
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not sure about the entr_detr_env_moisture_deficit_b_ED_MF
not being needed at some point @yairchn ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep the entrainment functions that are there
1d6fcb5
to
960f5c0
Compare
bors r+ |
Remove unused functions, fix some typos. I don't think these extra functions are needed, but it would be nice to get confirmation.