Remove unused ref state properties #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 12, 2021
376: Remove unused ref state properties r=charleskawczynski a=charleskawczynski Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 12, 2021
375: Prepping for injecting the use of ClimaCore fields r=charleskawczynski a=charleskawczynski
This PR
- Changes `self` ->`surf`/`sim` where appropriate
- Renames `state` -> `prog`
- Introduces `State` struct:
```julia
struct State{P, A, T, D}
prog::P
aux::A
tendencies::T
diagnostics::D
end
```
- Adds `grid` and `state` to the argument list for several methods
- Updates dycore API accordingly
Sorry if this is disruptive! 😬
376: Remove unused ref state properties r=charleskawczynski a=charleskawczynski
377: Temporarily remove windows 1.6 CI r=charleskawczynski a=charleskawczynski
I'm seeing some strange failures in #375 and #376. This PR temporarily removes windows 1.6 CI.
Co-authored-by: Charles Kawczynski <[email protected]>
|
bors r- |
charleskawczynski
force-pushed
the
ck/refactor3
branch
from
3b5b9e6
to
e91d147
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.