Wip on summing all rain tendencies #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
force-pushed
the
aj/rain_tendencies_apply
branch
2 times, most recently
from
8c71919
to
1ebcab1
Compare
|
There are some tiny changes for Rico case. But the profiles look almost indistinguishable to me |
trontrytel
force-pushed
the
aj/rain_tendencies_apply
branch
2 times, most recently
from
6491c6f
to
d08f18b
Compare
yairchn
reviewed
Oct 12, 2021
| TS::TimeStepping, | ||
| ) | ||
| @inbounds for k in real_center_indices(rain_var.grid) | ||
| rain_var.QR.values[k] += |
There was a problem hiding this comment.
should we have a max(...,0) here to ensure that QR is positive?
There was a problem hiding this comment.
If we do it here we would not be conserving mass anymore. Since the same tendencies need to be subtracted from qt. I think a better strategy is to have your scheme not break with small negatives for qr
trontrytel
force-pushed
the
aj/rain_tendencies_apply
branch
from
d08f18b
to
cf41616
Compare
|
bors r+ |
charleskawczynski
referenced
this pull request
Oct 16, 2021
414: Bump version r=charleskawczynski a=charleskawczynski Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finished the rain cleanup. All tendencies are calculated and then applied in one place.
@charleskawczynski - lmk what other changes to names/arrays etc you want done at this point. Or is it enough to leave for now and wait for a new timestepper?