-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solve grid mean equations explicitly #343
Conversation
4ba9f41
to
9bade01
Compare
9bade01
to
170cf67
Compare
@@ -351,11 +351,11 @@ function SP(namelist_defaults) | |||
namelist["meta"]["casename"] = "SP" | |||
|
|||
# this case is resolution dependent, we should check why | |||
namelist["grid"]["nz"] = 256 | |||
namelist["grid"]["dz"] = 8 | |||
namelist["grid"]["nz"] = 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SP does not work with dt=1 I had to make dz different. Change in the resolution effect SP, I have seen it before - I think something is off with the way the case is coded
@@ -128,7 +128,7 @@ function default_namelist(case_name::String) | |||
namelist_defaults["thermodynamics"]["quadrature_type"] = "log-normal" #"gaussian" or "log-normal" | |||
|
|||
namelist_defaults["time_stepping"] = Dict() | |||
namelist_defaults["time_stepping"]["dt"] = 10.0 | |||
namelist_defaults["time_stepping"]["dt"] = 7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at default dt =10 some minor instabilities still appear in diffusive cases such as dycoms and in the lower (boundary layer) of ARM
src/Turbulence_PrognosticTKE.jl
Outdated
write_profile(Stats, "diffusive_flux_qt", edmf.diffusive_flux_qt) | ||
write_profile(Stats, "diffusive_flux_u", edmf.diffusive_flux_u) | ||
write_profile(Stats, "diffusive_flux_v", edmf.diffusive_flux_v) | ||
# write_profile(Stats, "diffusive_flux_h", edmf.diffusive_flux_h) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could either remove these diagnostics of handle them properly - depending on what do you think? These are useful diagnostic in then future but the entire diagnostic mechanism would probably change
GMV.QT.tendencies[k] += (GMV.QT.new[k] - GMV.QT.values[k]) * TS.dti | ||
GMV.U.tendencies[k] += (GMV.U.new[k] - GMV.U.values[k]) * TS.dti | ||
GMV.V.tendencies[k] += (GMV.V.new[k] - GMV.V.values[k]) * TS.dti | ||
function GMV_update(grid::Grid, GMV::GridMeanVariables, TS::TimeStepping) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I move 'update' from 'src/Variables.jl' to here - I believe it is more correct for this function to be here - in the future we could collated all update functions (up, en, gm) into a single function
tendencies = field(grid, loc) | ||
if kind != "scalar" && kind != "velocity" | ||
print("Invalid kind setting for variable! Must be scalar or velocity") | ||
end | ||
return new{typeof(values)}(values, new, tendencies, loc, bc, kind, name, units) | ||
return new{typeof(values)}(values, tendencies, loc, bc, kind, name, units) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more 'new' in GMV!
4ba3b53
to
40dea7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some of the results have degraded (e.g., some pretty strong oscillations)
40dea7b
to
c3bba9f
Compare
yes it was time-stepping , I updated the time steps lets see how it looks now. |
9456b52
to
e1dbb55
Compare
1012f5d
to
d059f09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bomex / life cycle results are now looking better with the smaller timestep.
96f3688
to
d903cbf
Compare
Neiuwstadt needs a smaller tilmestep (see contours). |
01377e7
to
ac2cd46
Compare
ac2cd46
to
bc1ba0f
Compare
Bors r+ |
414: Bump version r=charleskawczynski a=charleskawczynski Co-authored-by: Charles Kawczynski <[email protected]>
No description provided.