-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change grid,ref_state to get_grid,reference_state #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2021
33: Change grid,ref_state to get_grid,reference_state r=charleskawczynski a=charleskawczynski It'd be nice to use `grid` and `ref_state` for local variables. hopefully `grid` will be available everywhere at some point, so `get_grid` may be temporary. Co-authored-by: Charles Kawczynski <[email protected]>
Build failed: |
charleskawczynski
force-pushed
the
ck/names
branch
from
July 21, 2021 04:08
7cd1160
to
99edc35
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2021
33: Change grid,ref_state to get_grid,reference_state r=charleskawczynski a=charleskawczynski It'd be nice to use `grid` and `ref_state` for local variables. hopefully `grid` will be available everywhere at some point, so `get_grid` may be temporary. Co-authored-by: Charles Kawczynski <[email protected]>
Build failed: |
charleskawczynski
force-pushed
the
ck/names
branch
from
July 21, 2021 04:40
99edc35
to
b2b71da
Compare
bors r+ |
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=====================================
Coverage 0.02% 0.02%
=====================================
Files 22 22
Lines 3467 3467
=====================================
Hits 1 1
Misses 3466 3466
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be nice to use
grid
andref_state
for local variables. hopefullygrid
will be available everywhere at some point, soget_grid
may be temporary.