Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #31

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Cleanup #31

merged 1 commit into from
Jul 21, 2021

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jul 20, 2021 •
edited
Loading

This PR:

  • Deletes some unused and commented code
  • Moves some of the outer constructors to where the types are defined.

@charleskawczynski charleskawczynski force-pushed the ck/cleanup branch 3 times, most recently from ada7396 to 8aa9190 Compare July 20, 2021 23:00
@charleskawczynski
Copy link
Member Author

MSE tables had to be udpated because we are removing the pi definition, which had less precision than Julia's builtin definition.

@charleskawczynski charleskawczynski force-pushed the ck/cleanup branch 3 times, most recently from aa7962c to b5b46c9 Compare July 20, 2021 23:30
@charleskawczynski
Remove unused and commented code
88f8402 
Convert outer constructors to inner constructors

Use pi symbol

Update mse tables
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 21, 2021

Build succeeded:

@bors bors bot merged commit c4ddd47 into main Jul 21, 2021
@bors bors bot deleted the ck/cleanup branch July 21, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel Awaiting requested review from trontrytel

@szy21 szy21 Awaiting requested review from szy21

@yairchn yairchn Awaiting requested review from yairchn

@haakon-e haakon-e Awaiting requested review from haakon-e

@jiahe23 jiahe23 Awaiting requested review from jiahe23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski