Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal experimental clima parameters #134

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add internal experimental clima parameters #134

merged 1 commit into from
Aug 16, 2021

Conversation

charleskawczynski
Copy link
Member

No description provided.

yairchn
yairchn approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakon-e
Copy link
Member

haakon-e commented Aug 16, 2021 •
edited
Loading

Shouldn't c_div also be added to

TurbulenceConvection.jl/integration_tests/utils/parameter_set.jl

Lines 15 to 23 in c0e2df6

function create_parameter_set(namelist)
TC = TurbulenceConvection
nt = (;
MSLP = 100000.0, # or grab from, e.g., namelist[""][...]
τ_cond_evap = TC.parse_namelist(namelist, "microphysics", "τ_cond_evap"; default = 10.0),
c_ε = TC.parse_namelist(namelist, "turbulence", "EDMF_PrognosticTKE", "entrainment_factor"),
)
return EarthParameterSet(nt)
end

otherwise it would always be 0.4, regardless of the namelist value, no?

@charleskawczynski
Copy link
Member Author

Shouldn't c_div also be added to

Good catch, thanks!

@charleskawczynski charleskawczynski force-pushed the ck/internal_clima_params branch 2 times, most recently from 0145150 to 9d641c6 Compare August 16, 2021 21:56
haakon-e
haakon-e approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@haakon-e haakon-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Build succeeded:

@bors bors bot merged commit 3faaf58 into main Aug 16, 2021
@bors bors bot deleted the ck/internal_clima_params branch August 16, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairchn yairchn yairchn approved these changes

@haakon-e haakon-e haakon-e approved these changes

Assignees
No one assigned
Labels
ClimaParameters 🎛️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charleskawczynski @haakon-e @yairchn