-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move pressure parameters to param_set #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
force-pushed
the
yc/pressure_parameters
branch
from
August 16, 2021 19:41
68170dc
to
d9f0fa4
Compare
charleskawczynski
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's just rebase/squash, first |
yairchn
force-pushed
the
yc/pressure_parameters
branch
from
August 16, 2021 20:08
2a6ea0c
to
b0cedf6
Compare
Bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 16, 2021
130: move pressure parameters to param_set r=yairchn a=yairchn Moving only pressure related parameters to parameter_set.jl Co-authored-by: yairchn <[email protected]>
Bors r- |
bors r+ |
Canceled. |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 16, 2021
130: move pressure parameters to param_set r=charleskawczynski a=yairchn Moving only pressure related parameters to parameter_set.jl Co-authored-by: yairchn <[email protected]>
yairchn
force-pushed
the
yc/pressure_parameters
branch
from
August 16, 2021 21:26
1164a3a
to
c523d0a
Compare
Canceled. |
Bors r+ |
bors r+ |
Already running a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving only pressure related parameters to parameter_set.jl