Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pressure parameters to param_set #130

Merged
merged 1 commit into from
Aug 16, 2021
Merged

move pressure parameters to param_set #130

merged 1 commit into from
Aug 16, 2021

Conversation

yairchn
Copy link
Member

@yairchn yairchn commented Aug 16, 2021

Moving only pressure related parameters to parameter_set.jl

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleskawczynski
Copy link
Member

Let's just rebase/squash, first

@yairchn
Copy link
Member Author

yairchn commented Aug 16, 2021

Bors r+

bors bot added a commit that referenced this pull request Aug 16, 2021
130: move pressure parameters to param_set r=yairchn a=yairchn

Moving only pressure related parameters to parameter_set.jl

Co-authored-by: yairchn <[email protected]>
@yairchn
Copy link
Member Author

yairchn commented Aug 16, 2021

Bors r-

@charleskawczynski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Canceled.

@charleskawczynski
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 16, 2021
130: move pressure parameters to param_set r=charleskawczynski a=yairchn

Moving only pressure related parameters to parameter_set.jl

Co-authored-by: yairchn <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Canceled.

@yairchn
Copy link
Member Author

yairchn commented Aug 16, 2021

Bors r+

@charleskawczynski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

@bors bors bot merged commit 7ed6136 into main Aug 16, 2021
@bors bors bot deleted the yc/pressure_parameters branch August 16, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants