Upgrade to latest deps, use new clima parameter handling #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/climaparams
branch
7 times, most recently
from
7908ccb
to
1ae864b
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 18, 2022
1192: Upgrade to latest deps, use new clima parameter handling r=charleskawczynski a=charleskawczynski This PR: - Upgrades to the latest version of Thermodynamics.jl - Upgrades to the latest version of CloudMicrophysics.jl - Upgrades to the latest version of SurfaceFluxes.jl all of which use to latest handling of clima parameters. Accordingly, this PR also adjusts how TurbulenceConvection handles its own clima parameters. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/climaparams
branch
from
1ae864b
to
7d338d7
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 18, 2022
1192: Upgrade to latest deps, use new clima parameter handling r=charleskawczynski a=charleskawczynski This PR: - Upgrades to the latest version of Thermodynamics.jl - Upgrades to the latest version of CloudMicrophysics.jl - Upgrades to the latest version of SurfaceFluxes.jl all of which use to latest handling of clima parameters. Accordingly, this PR also adjusts how TurbulenceConvection handles its own clima parameters. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/climaparams
branch
2 times, most recently
from
2ff5ba6
to
229ffba
Compare
|
I was really thrown off for a minute with the recent buildkite runs-- the results from the duals test looked completely different from the vanilla case. But then I realized that |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 18, 2022
1192: Upgrade to latest deps, use new clima parameter handling r=charleskawczynski a=charleskawczynski This PR: - Upgrades to the latest version of Thermodynamics.jl - Upgrades to the latest version of CloudMicrophysics.jl - Upgrades to the latest version of SurfaceFluxes.jl all of which use to latest handling of clima parameters. Accordingly, this PR also adjusts how TurbulenceConvection handles its own clima parameters. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/climaparams
branch
from
229ffba
to
823a3a7
Compare
|
bors r+ |
|
Build succeeded: |
This was referenced Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
all of which use to latest handling of clima parameters. Accordingly, this PR also adjusts how TurbulenceConvection handles its own clima parameters.