Merge #575

575: Add post-run tests, error if we do not run to t_max r=costachris a=charleskawczynski

Closes #574.

Co-authored-by: Charles Kawczynski <[email protected]>

integration_tests/ARM_SGP.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/Bomex.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/DYCOMS_RF01.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/DryBubble.jl

@@ -31,3 +31,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/GABLS.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/GATE_III.jl

@@ -15,3 +15,5 @@ namelist["meta"]["uuid"] = "01"
 ds_tc_filename = @time main(namelist; time_run = true)
 
 @testset "GATE_III" begin end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/LES_driven_SCM.jl

@@ -42,3 +42,5 @@ end
     nothing
 
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/Nieuwstadt.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/Rico.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/SP.jl

@@ -31,3 +31,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/Soares.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/TRMM_LBA.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/life_cycle_Tan2018.jl

@@ -37,3 +37,5 @@ end
     end
     nothing
 end
+
+include(joinpath("utils", "post_run_tests.jl"))

integration_tests/utils/generate_namelist.jl

@@ -401,7 +401,7 @@ function LES_driven_SCM(namelist_defaults)
     namelist["grid"]["nz"] = 200
 
     namelist["stats_io"]["frequency"] = 10.0
-    namelist["time_stepping"]["dt"] = 3.0
+    namelist["time_stepping"]["dt"] = 2.0
     namelist["time_stepping"]["t_max"] = 3600.0 * 6
 
     # use last 6 hours of LES simulation to drive LES

integration_tests/utils/main.jl

@@ -447,6 +447,7 @@ function run(sim::Simulation1d)
     )
 
     sim.skip_io || TC.close_files(sim.Stats) # #removeVarsHack
+    first(sol.t) == sim.TS.t_max || error("Could not run to t_max")
     return
 end
 

integration_tests/utils/mse_tables.jl

@@ -142,12 +142,12 @@ all_best_mse["TRMM_LBA"]["Hvar_mean"] = 4347.874034179779
 all_best_mse["TRMM_LBA"]["QTvar_mean"] = 2834.632990323496
 #
 all_best_mse["LES_driven_SCM"] = OrderedCollections.OrderedDict()
-all_best_mse["LES_driven_SCM"]["qt_mean"] = 8.375126616070798
-all_best_mse["LES_driven_SCM"]["v_mean"] = 3.234280171966482
-all_best_mse["LES_driven_SCM"]["u_mean"] = 1.134423861786145
-all_best_mse["LES_driven_SCM"]["temperature_mean"] = 0.0033437098531422594
-all_best_mse["LES_driven_SCM"]["ql_mean"] = 412.3892161833214
-all_best_mse["LES_driven_SCM"]["thetal_mean"] = 0.003642974955538725
+all_best_mse["LES_driven_SCM"]["qt_mean"] = 8.435279342878445
+all_best_mse["LES_driven_SCM"]["v_mean"] = 3.2617073734123214
+all_best_mse["LES_driven_SCM"]["u_mean"] = 1.148743169726484
+all_best_mse["LES_driven_SCM"]["temperature_mean"] = 0.003358421606334859
+all_best_mse["LES_driven_SCM"]["ql_mean"] = 609.0141669187923
+all_best_mse["LES_driven_SCM"]["thetal_mean"] = 0.003659402887362492
 #
 #################################
 #################################

integration_tests/utils/post_run_tests.jl

@@ -0,0 +1,22 @@
+@testset "Post-run tests" begin
+    isnan_or_inf(x) = isnan(x) || isinf(x)
+    NC.Dataset(ds_tc_filename, "r") do ds
+        profile = ds.group["profiles"]
+        @test !any(isnan_or_inf.(Array(profile["qt_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["updraft_area"])))
+        @test !any(isnan_or_inf.(Array(profile["updraft_w"])))
+        @test !any(isnan_or_inf.(Array(profile["updraft_qt"])))
+        @test !any(isnan_or_inf.(Array(profile["updraft_thetal"])))
+        @test !any(isnan_or_inf.(Array(profile["u_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["tke_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["temperature_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["ql_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["qi_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["thetal_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["Hvar_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["QTvar_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["v_mean"])))
+        @test !any(isnan_or_inf.(Array(profile["qr_mean"])))
+    end
+    nothing
+end