Convenience kwargs in JLD2OutputWriter constructor for averaging output
#887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JLD2OutputWriter constructor
|
Ah, it looks like I accidentally branched this PR from |
glwagner
changed the title
OutputWriter constructors for averaging outputJLD2OutputWriter constructor for averaging output
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 71.34% 71.39% +0.05%
==========================================
Files 187 187
Lines 5276 5289 +13
==========================================
+ Hits 3764 3776 +12
- Misses 1512 1513 +1
Continue to review full report at Codecov.
|
ali-ramadhan
approved these changes
Sep 3, 2020
| # Convert each output to WindowedTimeAverage if time_averaging_window is specified | ||
| if !isnothing(time_averaging_window) | ||
|
|
||
| !isnothing(iteration_interval) && error("Cannot specify iteration_interval with time_averaging_window.") |
There was a problem hiding this comment.
I might throw an ArgumentError as it's more specific and allows us to @test_throws the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the keyword arguments
time_averaging_windowandtime_averaging_strideto the constructors forJLD2OutputWriterandNetCDFOutputWriter. A non-nothingtime_averaging_windowtransforms all the specified output to aWindowedTimeAverage.I have implemented this feature for
JLD2OutputWriteronly so far.@ali-ramadhan, can you confirm that the pattern applied toJLD2OutputWriterwill work forNetCDFOutputWriter? I'm not 100% sure how it would work with the "slice" functionality of theNetCDFOutputWriter.Todo:
[ ] Implement convenience kwargs forNetCDFOutputWriterJLD2OutputWriter[ ] Tests forNetCDFOutputWriterEdit: I think we should just get this working for the
JLD2OutputWriterfor now. TheNetCDFOutputWriterneeds a bit of work anyways. We can extendNetCDFOutputWriterto averaged output once that preliminary work is complete.