Update dependencies

[ali-ramadhan]

Some regular maintenance

[ali-ramadhan]

Hmmm, so it looks like tests take longer now so Travis CI and GitLab CI will more often than not time out and fail 😞

Maybe it's time to split up the tests into 3-4 smaller jobs?

[navidcy]

I don't understand why you have the Manifest.toml? With proper use of the [compat] section in Project.toml there is no need to have the Manifest.toml in the package (and thus no need to keep updating it). Am I missing something?

[glwagner]

@navidcy that is only true in theory I think when package versions can be inferred from the dependency tree. In reality we need to maintain the precise versions of packages that are used... ?

[ali-ramadhan]

@navidcy I think you're right that with proper [compat] bounds, a Manifest.toml is unnecessary. But I think that would mean that as developers we would have to be meticulous about updating lower and upper bounds of dependencies. In particular, if a bug is introduced in a dependency then it could cause our master branch to fail (unless we had very strict upper [compat] bounds and updated them regularly).

I guess I see strict [compat] bounds as saying that "our package is guaranteed to work as long as your dependencies lie between these versions" (might take a lot of testing to ensure all version combinations are fine), while just using a Manifest.toml with loose [compat] bounds is saying "our package is guaranteed to work with the versions prescribed in the Manifest.toml".

I like the Manifest.toml approach as it gives us more control: we only update dependencies when we're ready and deal with any new issues one-by-one before merging. And it lets us play around with upgrading/downgrading the version on different dependencies, e.g. CUDA.jl, without worrying about [compat] bounds.

[codecov]

Codecov Report

Merging #860 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #860   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files         187      187           
  Lines        5180     5180           
=======================================
  Hits         3673     3673           
  Misses       1507     1507           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46608d7...19390e0. Read the comment docs.

[ali-ramadhan]

Hmmm looks like it was TEST_GROUP=integration that went from taking ~20 minutes to ~32 minutes, enough to cause timeouts. We can live with this for now I suppose, can look into it in the future.