Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizes fill_halo_regions_open.jl #3792

Closed
wants to merge 6 commits into from
Closed

Optimizes fill_halo_regions_open.jl #3792

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58ba9f8
Update fill_halo_regions_open.jl
jagoosw Sep 25, 2024
0e97e45
fix spurious kernel launching
jagoosw Sep 26, 2024
45245b3
formatting
jagoosw Sep 27, 2024
924afaa
stream lined getting fill function and fill size
jagoosw Sep 30, 2024
680b7c2
oops
jagoosw Sep 30, 2024
7ffeac7
hopeflly fixed now
jagoosw Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/BoundaryConditions/fill_halo_regions_open.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ function fill_open_boundary_regions!(field, boundary_conditions, indices, loc, g
return nothing
end

fill_open_boundary_regions!(fields::NTuple, boundary_conditions, indices, loc, grid, args...; kwargs...) =
[fill_open_boundary_regions!(field, boundary_conditions[n], indices, loc[n], grid, args...; kwargs...) for (n, field) in enumerate(fields)]

fill_open_boundary_regions!(fields::NTuple, boundary_conditions, indices, loc, grid, args...; kwargs...) =
ntuple(n->fill_open_boundary_regions!(fields[n], boundary_conditions[n], indices, loc[n], grid, args...; kwargs...), Val(length(fields)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fill_open_boundary_regions!(fields::NTuple, boundary_conditions, indices, loc, grid, args...; kwargs...) =
ntuple(n->fill_open_boundary_regions!(fields[n], boundary_conditions[n], indices, loc[n], grid, args...; kwargs...), Val(length(fields)))
function fill_open_boundary_regions!(fields::NTuple, bcs, indices, loc, args...; kw...)
N = length(fields)
return ntuple(n -> fill_open_boundary_regions!(fields[n], bcs[n], indices, loc[n], args...; kw...), Val(N))
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't read the code, we've little to show for all our hard work


# for regular halo fills
@inline left_velocity_open_boundary_condition(boundary_condition, loc) = nothing
Expand Down