Resize bottom field when using with_halo on ImmersedBoundaryGrid
#3138
Conversation
glwagner
changed the title
with_halo on ImmersedBoundaryGridwith_halo on ImmersedBoundaryGrid
| using Oceananigans.Fields: location, ZReducedField, Field | ||
|
|
||
| instantiate(T::Type) = T() | ||
| instantiate(t) = t |
There was a problem hiding this comment.
It's ok to redefine instantiate here, since it makes the code easier to read (ie a case where "Write Everything Twice" (WET) is better than "Don't Repeat Yourself" (DRY). Just FYI for the future.
There was a problem hiding this comment.
just want to make this pass first
https://buildkite.com/clima/oceananigans/builds/11941#01890352-3b10-49b6-98a3-0745c630a86c
then of course I agree on the comment
Co-authored-by: Gregory L. Wagner <[email protected]>
|
@simone-silvestri the issue which this was meant to close is now closed. (See #3137 (comment)) Should we close this PR as well? |
|
Does that PR also handle distributed grids? Because that was a problem that should be solved by this PR. If that is the case, we can close this one |
That issue had nothing to do with anything distributed. So if this fixes some issue with distributed grid then maybe it should be kept. Although it seems stale... :( |
closes #3137