-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Slurm pipeline for performance regression testing. #280
Conversation
Former-commit-id: 2fad83c
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 62.51% 62.51%
=======================================
Files 23 23
Lines 883 883
=======================================
Hits 552 552
Misses 331 331 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
- Coverage 62.6% 62.51% -0.1%
=========================================
Files 70 23 -47
Lines 2054 883 -1171
=========================================
- Hits 1286 552 -734
+ Misses 768 331 -437
Continue to review full report at Codecov.
|
@simonbyrne Sounds like you guys had some issues with Slurm CI? If so I'll close this PR and search for another place to test and benchmark multi-GPU stuff. |
Sorry @ali-ramadhan for not replying. I'm still trying to iron out the kinks in our current set up (we get failures pretty often for unknown reasons). Also I was hoping to figure out a container system. |
2fad83c
to
45bf8a8
Compare
Closing this PR for now. Will reopen once we consider Slurm CI again, potentially once we add MPI support with PR #590. |
Right now only 1 benchmark job is run to check for performance regression, which is important seeing as sometimes we introduce rogue bugs that kill performance.
cc @simonbyrne will this work with the Slurm CI/CliMA bot framework you've set up? Will be awesome to start using it. No MPI stuff yet but will probably add some soon.