Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves plotting in tilted bottom boundary layer example #2704

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Conversation

tomchor
Copy link
Collaborator

@tomchor tomchor commented Aug 20, 2022

The video at the end of this example doesn't look optimal so I'm gonna try to improve it.

Preview should render here: https://clima.github.io/OceananigansDocumentation/previews/PR2704/generated/tilted_bottom_boundary_layer/

@navidcy navidcy self-requested a review August 20, 2022 02:46
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see the preview and merge :)

@navidcy
Copy link
Collaborator

navidcy commented Aug 22, 2022

Looks good, no?

@tomchor
Copy link
Collaborator Author

tomchor commented Aug 22, 2022

Looks good, no?

Definitely looks better. I wanna try to improve it a bit more though. Also I think the previous call to update_theme! didn't work here, although it works locally for me, so I removed it.

@tomchor tomchor requested a review from navidcy August 22, 2022 16:58
@tomchor tomchor merged commit ea6826f into main Aug 22, 2022
@tomchor tomchor deleted the tc/tilted_bbl branch August 22, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants