Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: instantiate main env separately #1573

Merged
merged 5 commits into from
Apr 13, 2021
Merged

docs: instantiate main env separately #1573

merged 5 commits into from
Apr 13, 2021

Conversation

simonbyrne
Copy link
Member

No description provided.

@ali-ramadhan
Copy link
Member

ali-ramadhan commented Apr 13, 2021

Thank you @simonbyrne!

@glwagner I tried to fix all_*_nodes so that we can set! reduced fields (which model.free_surface now is) but not sure if [] is the best solution.

If tests pass we should merge and tag v0.54.1.

@glwagner
Copy link
Member

Thank you @simonbyrne!

@glwagner I tried to fix all_*_nodes so that we can set! reduced fields (which model.free_surface now is) but not sure if [] is the best solution.

If tests pass we should merge and tag v0.54.1.

Looks like we need something that has length 1.

Thinking about this more I think we actually probably want a new set! function for ReducedField so that users can use a two-argument function, rather than a three-argument function with a meaningless third argument.

For the sake of this PR though I'll just put a band-aid in if that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants