Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster, cleaner pressure solvers for all topologies on CPUs and GPUs #1338

Merged
merged 40 commits into from
Feb 8, 2021
Merged

Faster, cleaner pressure solvers for all topologies on CPUs and GPUs #1338

merged 40 commits into from
Feb 8, 2021

Commits on Dec 9, 2020

  1. Ignore benchmark outputs

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    19b2536 View commit details
    Browse the repository at this point in the history

  2. Benchmark 3D FFTs vs. 3 x 1D FFTs

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    65cd35c View commit details
    Browse the repository at this point in the history

  3. Start refactoring pressure solver

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    c7e6609 View commit details
    Browse the repository at this point in the history

  4. New pressure solver instantiates

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b26ccf9 View commit details
    Browse the repository at this point in the history

  5. Tests pass for triply periodic

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    98eec62 View commit details
    Browse the repository at this point in the history

  6. Fix normalization factor

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    0f72d85 View commit details
    Browse the repository at this point in the history

  7. Test all the topologies

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    96beb31 View commit details
    Browse the repository at this point in the history

  8. Eigenvalues not wavenumbers

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    d35b503 View commit details
    Browse the repository at this point in the history

  9. GPU pressure solver working for triply periodic

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b1661c6 View commit details
    Browse the repository at this point in the history

  10. Transforms handle their own normalization

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    065d9b2 View commit details
    Browse the repository at this point in the history

  11. Twiddle factors and more working topologies

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    95ccab3 View commit details
    Browse the repository at this point in the history

  12. Preliminary infrastructure for non-batched GPU transforms

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    649970e View commit details
    Browse the repository at this point in the history

  13. Finally nuke crufty old pressure solvers!

    @ali-ramadhan
    ali-ramadhan committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    1e32d8f View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Fix Benchmarks environment

    @ali-ramadhan
    ali-ramadhan committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    20c1385 View commit details
    Browse the repository at this point in the history

  2. Poisson solver sandbox testing

    @ali-ramadhan
    ali-ramadhan committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    2b8af1c View commit details
    Browse the repository at this point in the history

  3. 2D sandbox testing looks good

    @ali-ramadhan
    ali-ramadhan committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1f4ec24 View commit details
    Browse the repository at this point in the history

  4. 3D sandbox testing was helpful

    @ali-ramadhan
    ali-ramadhan committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    cd14de6 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Refactor pressure solver divergence-free test

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    0dea76f View commit details
    Browse the repository at this point in the history

  2. Isolate index permutations and add citations

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d530dc0 View commit details
    Browse the repository at this point in the history

  3. Move index permutation to DiscreteTransform

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    385d119 View commit details
    Browse the repository at this point in the history

  4. 3D pressure solve for non-batch dim finally passes

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3f9dd71 View commit details
    Browse the repository at this point in the history

  5. Lots of DiscreteTransform dispatch

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5d8e821 View commit details
    Browse the repository at this point in the history

  6. Apply transforms in tuple order

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d475d6e View commit details
    Browse the repository at this point in the history

  7. Sorry about all the if statements...

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    84cbfdc View commit details
    Browse the repository at this point in the history

  8. Gotta reshape before transposing

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    c71bcee View commit details
    Browse the repository at this point in the history

  9. Update Poisson solver convergence test

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b5df157 View commit details
    Browse the repository at this point in the history

  10. Cautiously optimistic that tests will pass

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    06c612e View commit details
    Browse the repository at this point in the history

  11. Test mode=2 as well

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f37462b View commit details
    Browse the repository at this point in the history

  12. That would explain why unit tests were fast

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8e70a46 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into ali/pressure-solver-tlc

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8aa7c4d View commit details
    Browse the repository at this point in the history

  14. Fix Benchmarks Manifest.toml

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5936e8d View commit details
    Browse the repository at this point in the history

  15. Fix tests

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    72c894f View commit details
    Browse the repository at this point in the history

  16. Benchmark all topologies!

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9439a12 View commit details
    Browse the repository at this point in the history

  17. Some renaming and now it's FFTBasedPoissonSolver

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    bd4f8f4 View commit details
    Browse the repository at this point in the history

  18. Yet another Cell -> Center

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5d0206b View commit details
    Browse the repository at this point in the history

  19. Benchmarking FFT-based Poisson solvers

    @ali-ramadhan
    ali-ramadhan committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    38d51d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Address PR review

    @ali-ramadhan
    ali-ramadhan committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    a9a25ae View commit details
    Browse the repository at this point in the history

  2. Bump version 0.47.0

    @ali-ramadhan
    ali-ramadhan committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    dbc1042 View commit details
    Browse the repository at this point in the history

  3. Address more PR comments and nuke sandbox

    @ali-ramadhan
    ali-ramadhan committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e7c6237 View commit details
    Browse the repository at this point in the history

  4. Last commit did not show up for some reason...

    @ali-ramadhan
    ali-ramadhan committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e953459 View commit details
    Browse the repository at this point in the history