Add thermocline with variable N²(z) #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
I think this is nice! It's nice to have a continuous function for convergence studies, too. It's annoying that the Manifest is conflicting. @ali-ramadhan should I try to fix that?
adelinehillier
approved these changes
Nov 27, 2020
|
Ah thankfully it was just a minor conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just changes the thermocline in
three_layer_constant_fluxes.jlto have a variable N²(z) structure parameterized by a fitted cubic function.The idea is to enrich the training data as convection is no longer entraining into a fluid layer of constant stratification, although might need to play around with the model parameters to get a temperature profile where the N²(z) structure is significant (and it still finishes in a reasonable amount of time).
To give some idea of what it looks like: