add Milankovitch cycles #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
===========================================
+ Coverage 98.71% 100.00% +1.28%
===========================================
Files 3 3
Lines 78 87 +9
===========================================
+ Hits 77 87 +10
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
szy21
reviewed
Jun 2, 2022
claresinger
force-pushed
the
try_rebase
branch
2 times, most recently
from
c10ef96
to
a264ae3
Compare
tapios
approved these changes
Jun 3, 2022
claresinger
commented
Jun 3, 2022
…ealing with dates to make Insolation work with Float32 values. Add tests and documentation for the new Milankovitch cycles. Specifically test that long-term variations in vernal equinox and perihelion date are correct. Change mean anomaly to be calculated relative to epoch not to vernal equinox. Remove Manifest files. Update epoch from float to string->DateTime.
|
bors try |
|
bors r+ |
tryBuild succeeded: |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27 and closes #29
Docs preview here: https://clima.github.io/Insolation.jl/previews/PR34