This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Add turbulence statistics diagnostics #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slifer50
requested review from
smarras79 and
akshaysridhar
and removed request for
smarras79
|
bors try |
tryBuild succeeded: |
kpamnany
reviewed
Jul 27, 2020
kpamnany
reviewed
Jul 27, 2020
|
This doesn't seem sufficiently general a solution to me. |
@kpamnany I would have liked to have this included in a diagnostics group but I need access to data from previous time steps and I'm not sure how to approach this from within the diagnostics framework. |
kpamnany
force-pushed
the
yt/turbulence_stats
branch
2 times, most recently
from
0e2ebf3
to
89b6236
Compare
kpamnany
force-pushed
the
yt/turbulence_stats
branch
2 times, most recently
from
cb19c2e
to
e22da78
Compare
|
@kpamnany Everything looks good to me. Awesome work! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2020
1388: Add turbulence statistics diagnostics r=kpamnany a=slifer50 # Description Defines a callback for calculating volumetrically averaged dimensionless kinetic energy and dissipation Co-authored-by: yassine <[email protected]>
|
Build failed: |
Energy + Dissipation calculation. Co-authored-by: K Pamnany <[email protected]>
kpamnany
force-pushed
the
yt/turbulence_stats
branch
from
e22da78
to
10914ff
Compare
kpamnany
force-pushed
the
yt/turbulence_stats
branch
from
10914ff
to
f40360d
Compare
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines a callback for calculating volumetrically averaged dimensionless kinetic energy and dissipation
I have built a module that allows for a callback to calculate volumetrically averaged dimensionless kinetic energy and kinetic energy dissipation. This will be useful as it replaces the tedious procedure of calculating these during post-processing. These represent useful insight into certain turbulence dominated cases like the Taylor-Green vortex.
tests/runtests.jljulia .dev/climaformat.jl .For review by CLIMA developers
julia .dev/format.jlhas been run in a separate commit.