Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds scm relaxation timescale parameters #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Julians42
Copy link

@Julians42 Julians42 commented Oct 11, 2024

Purpose

Adds 4 parameters to allow SCM to relax to forcing file profile towards forcing file profile (for use in GCM driven and Reanalysis driven cases). These should be changed to switch between shallow and deep convection cases.

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (64914a0) to head (1a1f8cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files           2        2           
  Lines         134      134           
=======================================
  Hits          132      132           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion. For new users end_height may sound like there is no relaxation above that height. Maybe something like maximum_relaxation_height is more clear.

end -> maximum

start -> minimum
@Julians42 Julians42 force-pushed the j/adds_scm_forcing_parameters branch from 35c0e3f to 1a1f8cd Compare October 11, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants