Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClimaLand: all CO2 fluxes in mol CO2 m-2 s-1 #205

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

AlexisRenchon
Copy link
Member

@AlexisRenchon AlexisRenchon commented Aug 19, 2024

This PR goes along with ClimaLand PR #731,
we are refactoring ClimaLand to express all CO2 fluxes in mol CO2 m-2 s-1, previously there was some in
g C m-2 s-1 and some in mol CO2 m-2 s-1

This PR goes along with ClimaLand PR #731,
we are refactoring ClimaLand to express all CO2 fluxes
in mol CO2 m-2 s-1, previously there was some in
g C m-2 s-1 and some in mol CO2 m-2 s-1
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (9e6b5ab) to head (870475d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #205       +/-   ##
=========================================
+ Coverage      0   98.50%   +98.50%     
=========================================
  Files         0        2        +2     
  Lines         0      134      +134     
=========================================
+ Hits          0      132      +132     
- Misses        0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexisRenchon AlexisRenchon marked this pull request as ready for review August 20, 2024 17:38
@AlexisRenchon AlexisRenchon merged commit 53f5049 into main Aug 20, 2024
9 checks passed
@Sbozzolo
Copy link
Member

Sbozzolo commented Aug 20, 2024

Note that with change you triggered a breaking release of ClimaParams (packages using this parameter will obtain a new copy of ClimaParams that does not have this parameter and will crash).

Could you open an issue in this repo regarding the lack of documentation and guidance on how to add/remove/rename parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants