P3 parameters for sink terms #192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 2 2
Lines 134 134
=======================================
Hits 132 132
Misses 2 2 ☔ View full report in Codecov by Sentry. |
src/parameters.toml
Outdated
| type = "float" | ||
| description = "Density of water in kg/m3" | ||
|
|
||
| [freeze_temp] |
There was a problem hiding this comment.
We already have that one defined here:
ClimaParams.jl/src/parameters.toml
Line 1939 in 0b7edb9
src/parameters.toml
Outdated
| @@ -1599,6 +1604,26 @@ value = 6 | |||
| type = "float" | |||
| description = "Limiter for shape parameter mu for ice in P3 scheme. See eq 3 in Morrison and Milbrandt 2015. Units: [-]" | |||
|
|
|||
| [water_density] | |||
There was a problem hiding this comment.
We already have that one defined:
ClimaParams.jl/src/parameters.toml
Line 1915 in 0b7edb9
src/parameters.toml
Outdated
| [p3_ventillation_a] | ||
| value = 0.78 | ||
| type = "float" | ||
| description = "a coefficient for ventillation factor calculations in p3 tendencies" |
There was a problem hiding this comment.
| description = "a coefficient for ventillation factor calculations in p3 tendencies" | |
| description = "a coefficient for ventillation factor calculations in p3 tendencies, unitless. " |
There was a problem hiding this comment.
Do we have a reference for ventilation coeff values? If not we can put From Seifert and Beheng, 2006. DOI: 10.1007/s00703-005-0112-4
src/parameters.toml
Outdated
| [p3_ventiallation_b] | ||
| value = 0.308 | ||
| type = "float" | ||
| description = "b coefficient for ventillation factor calculations in p3 tendencies" |
There was a problem hiding this comment.
| description = "b coefficient for ventillation factor calculations in p3 tendencies" | |
| description = "b coefficient for ventillation factor calculations in p3 tendencies, unitless" |
There was a problem hiding this comment.
We should:
- delete
water_densityandfreeze_tempand use the values that are already defined in ClimaParams. - bump the version here: to
Line 4 in 49fc081
10.7so that we can make a release when this is merged.
Aside from that it's good to go, after squashing and rebasing
Purpose
This PR aims to add the missing parameters for the p3 sink term calculations
To-do
Content