-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bucket model parameters #183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 2 2
Lines 134 134
=======================================
Hits 132 132
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just added a couple more parameters to the Bucket model, which would be good to add to CP as well:
f_bucket = 0.75
f_snow = 0.0
p = 1
I also double checked another model and I think these would be better defaults:
bucket capacity = 0.2 (m)
critical snow amount = 0.05 (m)
Thank you, Nat!! this is a huge help to us.
oh, and, we can cite the SLIM model (Laguë et al 2019) for all values |
@kmdeck Thank you for the comments! One question, does critical snow amount refer to the parameter critical_snow_water_equivalent or another one? |
critical snow water equivalent, thank you! |
3df2b67
to
afa3dcf
Compare
afa3dcf
to
455f145
Compare
No description provided.