Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket model parameters #183

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Add bucket model parameters #183

merged 2 commits into from
Feb 26, 2024

Conversation

nefrathenrici
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (a782e37) to head (a748020).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files           2        2           
  Lines         134      134           
=======================================
  Hits          132      132           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just added a couple more parameters to the Bucket model, which would be good to add to CP as well:
f_bucket = 0.75
f_snow = 0.0
p = 1

https://github.com/CliMA/ClimaLand.jl/blob/501829de0e4aee56408cdca64cbc3a237c5fa38e/src/standalone/Bucket/Bucket.jl#L251

I also double checked another model and I think these would be better defaults:
bucket capacity = 0.2 (m)
critical snow amount = 0.05 (m)

Thank you, Nat!! this is a huge help to us.

@kmdeck
Copy link
Member

kmdeck commented Feb 22, 2024

oh, and, we can cite the SLIM model (Laguë et al 2019) for all values

@nefrathenrici
Copy link
Member Author

I also double checked another model and I think these would be better defaults:
bucket capacity = 0.2 (m)
critical snow amount = 0.05 (m)

@kmdeck Thank you for the comments! One question, does critical snow amount refer to the parameter critical_snow_water_equivalent or another one?

@kmdeck
Copy link
Member

kmdeck commented Feb 22, 2024

I also double checked another model and I think these would be better defaults:
bucket capacity = 0.2 (m)
critical snow amount = 0.05 (m)

@kmdeck Thank you for the comments! One question, does critical snow amount refer to the parameter critical_snow_water_equivalent or another one?

critical snow water equivalent, thank you!

@nefrathenrici nefrathenrici force-pushed the ne/bucket_params branch 5 times, most recently from 3df2b67 to afa3dcf Compare February 26, 2024 18:34
@nefrathenrici nefrathenrici merged commit b2d7855 into main Feb 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants