Do not fail when p.start_date is not available #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisRenchon
approved these changes
May 21, 2024
There was a problem hiding this comment.
I think the commit message just has a title?
Since this is not a permanent solution, should we just comment issue #14 but not close it? (so that we know we will need to improve this eventually).
This commits makes having "start_date" in the cache optional. When it is available, the calendar dates will be saved to the NetCDF file. Otherwise, only the simulation time will be stored
I updated the commit message. I think that #14 can still be closed, but we can revisit support for start date when needs arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete solution, but at least ClimaDiagnostics will not fail if p.start_date is not available
Closes #14