Introduce z_sampling_method, remove disable_vertical_interpolation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 19, 2024
[skip ci] See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
force-pushed
the
gb/z_interpolation
branch
from
5ed5d43
to
488d712
Compare
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 19, 2024
[skip ci] See breaking change: CliMA/ClimaDiagnostics.jl#47
AlexisRenchon
approved these changes
May 21, 2024
Thank you! |
The NetCDF writer was originally designed for ClimaAtmos. As such, it uses some fake pressure levels for vertical sampling as default. This is generally not applicable/useful. This commit generalized the method two sample points on the vertical direction introducing a new type `AbstractZSamplingMethod`. `AbstractZSamplingMethod` has to concrete subtypes: - `LevelsMethod` (equivalent to `disable_vertical_interpolation`) - `FakePressureLevelsMethod` (equivalent to previously default behavior) This opens up the possibility to also define `LinearMethod`, for linear sampling, and `LogMethod`, for log sampling. The default was changed to `LevelsMethod` and `disable_vertical_interpolation` was deprecated.
Sbozzolo
force-pushed
the
gb/z_interpolation
branch
from
488d712
to
28e377e
Compare
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 21, 2024
[skip ci] See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 22, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sbozzolo
added a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
May 23, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
oalcabes
pushed a commit
to CliMA/ClimaAtmos.jl
that referenced
this pull request
Aug 30, 2024
See breaking change: CliMA/ClimaDiagnostics.jl#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NetCDF writer was originally designed for ClimaAtmos. As such, it uses some fake pressure levels for vertical sampling as default. This is generally not applicable/useful. This commit generalized the method to sample points on the vertical direction introducing a new type
AbstractZSamplingMethod.AbstractZSamplingMethodhas to concrete subtypes:LevelsMethod(equivalent todisable_vertical_interpolation)FakePressureLevelsMethod(equivalent to previously default behavior)This opens up the possibility to also define
LinearMethod, for linear sampling, andLogMethod, for log sampling.The default was changed to
LevelsMethodanddisable_vertical_interpolationwas deprecated.Closes #6