Add developer guidelines #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 12e22c0.
AlexisRenchon
approved these changes
May 21, 2024
There was a problem hiding this comment.
This is helpful, thanks!
I like having all tests in test, and use the extras deps, it is cleaner and easier. The README.md is well written and easy to understand, I just found one typo.
I have a suggestion, maybe for another PR: what do you think of having a NEWS.md file?
Sbozzolo
force-pushed
the
gb/dev_guidelines
branch
from
72fdc0b
to
0e14f2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guidelines on how to do testing/formatting/documentation/commits and replaces undocumented formatting infrastructure with one that is documented (but non standard across CliMA packages).
Closes #40
Closes #32
Closes #31