Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downgrade workflow, fix lower bounds #2078

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Add downgrade workflow, fix lower bounds #2078

merged 6 commits into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. Switch from OrderedCollections to DataStructures

    The only data structure needed in OrderedDict, which is also provided by
    DataStructures (which is already a dependency of ClimaCore)
    Sbozzolo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b5c3348 View commit details
    Browse the repository at this point in the history
  2. Qualify IntervalSets

    Sbozzolo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ff6c501 View commit details
    Browse the repository at this point in the history
  3. Remove extra spaces

    Sbozzolo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2731c6b View commit details
    Browse the repository at this point in the history
  4. Remove DocStringExtensions

    It is only used in one place, where it can be easily inlined
    Sbozzolo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9665350 View commit details
    Browse the repository at this point in the history
  5. Add downgrade workflow, fix lower bounds

    This commit adds the downgrade github action and cleans up some incorrect lower
    bounds.
    Sbozzolo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b7de560 View commit details
    Browse the repository at this point in the history
  6. Rewrite unit_space test for floating point

    This test was failing with
    ```
    /home/runner/work/ClimaCore.jl/ClimaCore.jl/test/Spaces/unit_spaces.jl:58
      Expression: coord_slab[slab_index(4)] == Geometry.XPoint{FT}(5)
       Evaluated: XPoint(4.999999999999999) == XPoint(5.0)
    ```
    Sbozzolo committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5b99f3f View commit details
    Browse the repository at this point in the history